]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
i2c-pca-isa: Don't grab arbitrary resources
authorRene Herman <rene.herman@gmail.com>
Tue, 14 Oct 2008 15:30:03 +0000 (17:30 +0200)
committerJean Delvare <khali@mahadeva.delvare>
Tue, 14 Oct 2008 15:30:03 +0000 (17:30 +0200)
commitce5640330b10c6cecfbda50569b9f53c081d10c6
tree93a3cbb3ecea9be12b468781b36ea3039724ccb4
parent9df013b3e46c67dd3745df91eaccdc719118e0cc
i2c-pca-isa: Don't grab arbitrary resources

Grabbing ISA bus resources without anything or anyone telling us we
should can break boot on randconfig/allyesconfig builds by keeping
resources that are in fact owned by different hardware busy and does
as reported by Ingo Molnar.

Generally it's also dangerous to just poke at random I/O ports and
especially those in the range where other old easily confused ISA
hardware might live.

For this specialized I2C bus driver, insist that the user specifies
the resources before grabbing them.

The^WA user of this driver is a one time

echo "options i2c-pca-isa base=0x330 irq=10" >> /etc/modprobe.conf

away from the old behaviour.

Signed-off-by: Rene Herman <rene.herman@gmail.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
drivers/i2c/busses/i2c-pca-isa.c