]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
epoll: avoid kmemcheck warning
authorDavide Libenzi <davidel@xmailserver.org>
Tue, 29 Apr 2008 07:58:34 +0000 (00:58 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 29 Apr 2008 15:05:59 +0000 (08:05 -0700)
commitcdac75e6f2fec9abc21d0abb4e5d80720eeebb10
tree0962ee591a96d5ebbd8e572b4aa05fe725754eb2
parentb781ecb6a379f155568ef7093e38c6c1d857fe53
epoll: avoid kmemcheck warning

Epoll calls rb_set_parent(n, n) to initialize the rb-tree node, but
rb_set_parent() accesses node's pointer in its code.  This creates a
warning in kmemcheck (reported by Vegard Nossum) about an uninitialized
memory access.  The warning is harmless since the following rb-tree node
insert is going to overwrite the node data.  In any case I think it's
better to not have that happening at all, and fix it by simplifying the
code to get rid of a few lines that became superfluous after the previous
epoll changes.

Signed-off-by: Davide Libenzi <davidel@xmailserver.org>
Cc: Vegard Nossum <vegard.nossum@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/eventpoll.c