]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
IB/mad: Test ib_create_send_mad() return with IS_ERR(), not == NULL
authorJulien Brunel <brunel@diku.dk>
Thu, 7 Aug 2008 21:11:56 +0000 (14:11 -0700)
committerRoland Dreier <rolandd@cisco.com>
Thu, 7 Aug 2008 21:11:56 +0000 (14:11 -0700)
commitcd55ef5a10d1a2ea09853bc5fa40aadaf9f80614
treef26e6f9ba06171a5c404ba5220cba60ad53e2a34
parent6e86841d05f371b5b9b86ce76c02aaee83352298
IB/mad: Test ib_create_send_mad() return with IS_ERR(), not == NULL

In case of error, the function ib_create_send_mad() returns an ERR
pointer, but never returns a NULL pointer.  So testing the return
value for error should be done with IS_ERR, not by comparing with
NULL.

A simplified version of the semantic patch that makes this change is
as follows:

(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@correct_null_test@
expression x,E;
statement S1, S2;
@@
x = ib_create_send_mad(...)
<... when != x = E
if (
(
- x@p2 != NULL
+ ! IS_ERR ( x )
|
- x@p2 == NULL
+ IS_ERR( x )
)
 )
S1
else S2
...>
? x = E;
// </smpl>

Signed-off-by: Julien Brunel <brunel@diku.dk>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/core/mad_rmpp.c