]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[SCSI] libiscsi: fix missed iscsi_task_put in xmit error path
authorMike Christie <michaelc@cs.wisc.edu>
Mon, 16 Oct 2006 22:09:40 +0000 (18:09 -0400)
committerJames Bottomley <jejb@mulgrave.il.steeleye.com>
Wed, 25 Oct 2006 22:13:57 +0000 (15:13 -0700)
commitcd529a46e17b43976d05c1e2ece2676ec7941cc8
treeb52d86911134d1d35f44d12171950c9aab07c887
parent98644047916c24258fb47c3dab2bed8a44f53b83
[SCSI] libiscsi: fix missed iscsi_task_put in xmit error path

from bhalevy@gmail.com:

It looks like change 652 to libiscsi.c added some dead code around line
670
                if (rc) {
                        spin_unlock_bh(&conn->session->lock);
                        goto again;
                }

since 5 lines above we goto again if (rc).

It looks like the previous if (rc) should go away if we want to put the
ctask before
breaking out of the while loop with "goto again" (see following patch).

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/libiscsi.c