]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] bug: nfsd/nfs4xdr.c misuse of ERR_PTR()
authorAl Viro <viro@ftp.linux.org.uk>
Fri, 20 Oct 2006 06:28:44 +0000 (23:28 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Fri, 20 Oct 2006 17:26:39 +0000 (10:26 -0700)
commitcc45f0175088e000ac7493e5e3f05579b6f7d240
treecc53e59824097b45a39ca332b3451aedc43d4fe2
parentb7766da7f7395b74dec9e52005b7dac0d09391a4
[PATCH] bug: nfsd/nfs4xdr.c misuse of ERR_PTR()

a) ERR_PTR(nfserr_something) is a bad idea;
IS_ERR() will be false for it.
b) mixing nfserr_.... with -EOPNOTSUPP is
even worse idea.

nfsd4_path() does both; caller expects to get NFS protocol error out it if
anything goes wrong, but if it does we either do not notice (see (a)) or get
host-endian negative (see (b)).

IOW, that's a case when we can't use ERR_PTR() to return error, even though we
return a pointer in case of success.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Trond Myklebust <trond.myklebust@fys.uio.no>
Acked-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/nfsd/nfs4xdr.c