]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
W1: ds1wm.c msleep for reset
authorDavid Fries <david@fries.net>
Thu, 16 Oct 2008 05:05:01 +0000 (22:05 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 16 Oct 2008 18:21:50 +0000 (11:21 -0700)
commitcadd486cfc838ead0ad899db129cff9f61ef4267
tree947d21b781a12ba588fe6722575f2b7681c4458c
parent8e3dae2b4727dc216e2dc16d2f0271b5f31b680c
W1: ds1wm.c msleep for reset

Like the previous w1_io.c reset coments and msleep patch, I don't have the
hardware to verify the change, but I think it is safe.  It also helps to
see a comment like this in the code.  "We'll wait a bit longer just to be
sure." If they are going to calculate delaying 324.9us, but actually delay
500us, why not just give up the CPU and sleep?  This is designed for a
battery powered ARM system, avoiding busywaiting has to be good for
battery life.

I sent a request for testers March 7, 2008 to the Linux kernel mailing
list and two developers who have patches for ds1wm.c, but I didn't get
any respons.

Signed-off-by: David Fries <david@fries.net>
Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/w1/masters/ds1wm.c