]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[ARM] omap: fix inappropriate casting in gpio.c
authorRussell King <rmk@dyn-67.arm.linux.org.uk>
Fri, 5 Sep 2008 14:49:14 +0000 (15:49 +0100)
committerTony Lindgren <tony@atomide.com>
Mon, 8 Sep 2008 23:24:09 +0000 (16:24 -0700)
commitc931779463a5b3275908fd7b15f00445ef83ae43
tree46627d996ebdacf15635068d19dc738c1fbc890a
parent5027b225e2c56da0f49b5f8b518e93139c1a1d63
[ARM] omap: fix inappropriate casting in gpio.c

gpio.c wilfully casts physical addresses to void __iomem * and then
fixes them up at runtime using:

bank->base = IO_ADDRESS(bank->base);

where accesses prior to this fixup are via omap_read/omap_write, and
after are by __raw_read/__raw_write.  This doesn't lend itself to
static checking, nor to easy understanding of the code.

And so, OMAP_MPUIO_BASE gets to be the right type - integer like since
it's a physical address, not a MMIO pointer.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
arch/arm/plat-omap/gpio.c
arch/arm/plat-omap/include/mach/gpio.h