]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
IPC: cleanup some code and wrong comments about semundo list managment
authorPierre Peiffer <pierre.peiffer@bull.net>
Fri, 19 Oct 2007 06:40:55 +0000 (23:40 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Fri, 19 Oct 2007 18:53:48 +0000 (11:53 -0700)
commitc530c6ac7eb1d4ae1ff6b382d9211be446ee82c6
treef36b7323f4c60f859107f74014ae67da6d63d49f
parent1b531f213661657d6e1c55cf5c97f649d630c227
IPC: cleanup some code and wrong comments about semundo list managment

Some comments about sem_undo_list seem wrong.
About the comment above unlock_semundo:
"... If task2 now exits before task1 releases the lock (by calling
unlock_semundo()), then task1 will never call spin_unlock(). ..."

This is just wrong, I see no reason for which task1 will not call
spin_unlock... The rest of this comment is also wrong... Unless I
miss something (of course).

Finally, (un)lock_semundo functions are useless, so remove them
for simplification. (this avoids an useless if statement)

Signed-off-by: Pierre Peiffer <pierre.peiffer@bull.net>
Cc: Nadia Derbey <Nadia.Derbey@bull.net>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
ipc/sem.c