]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] device-mapper: list_versions fix
authorAlasdair G Kergon <agk@redhat.com>
Tue, 22 Nov 2005 05:32:33 +0000 (21:32 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Tue, 22 Nov 2005 17:14:31 +0000 (09:14 -0800)
commitc4cc66351a24da5feec298be2da59a85f68dd3ea
tree76b03b0bfa3d6db905b9b7e26997263b01cbe3ee
parentb6fcc80d03b41162ed88c3fb542aca9b654bc414
[PATCH] device-mapper: list_versions fix

In some circumstances the LIST_VERSIONS output is truncated because the size
calculation forgets about a 'uint32_t' in each structure - but the inclusion
of the whole of ALIGN_MASK frequently compensates for the omission.

This is a quick workaround to use an upper bound.  (The code ought to be fixed
to supply the actual size.)

Running 'dmsetup targets' may demonstrate the problem: when I run it, the last
line comes out as 'erro' instead of 'error'.  Consequently, 'lvcreate --type
error' doesn't work.

Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/md/dm-ioctl.c