]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
IPMI: don't init irq until ready
authorCorey Minyard <cminyard@mvista.com>
Thu, 18 Oct 2007 10:07:08 +0000 (03:07 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Thu, 18 Oct 2007 21:37:32 +0000 (14:37 -0700)
commitc45adc39156dfb0a296df218d62ba8b68cadf12e
treefd96c4475d246334b7e295e4f482af5d89422dcd
parente8c44319c691dfb4a0b039b095204c040df9b01a
IPMI: don't init irq until ready

Patrick found a race at startup.  Interrupts were being enabled for the IPMI
interface before the driver was really ready to handle them.  This could
result in an oops if something was pending on the interface at startup and
interrupt were already enabled (technically shouldn't happen, but need to
cover for this in real life).  So move the IRQ setup to the code that starts
the actual IPMI processing.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
Cc: Patrick Schoeller <Patrick.Schoeller@hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/char/ipmi/ipmi_si_intf.c