]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] Remove suspend() calls from shutdown path
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Thu, 4 Aug 2005 09:36:26 +0000 (11:36 +0200)
committerLinus Torvalds <torvalds@g5.osdl.org>
Thu, 4 Aug 2005 15:20:47 +0000 (08:20 -0700)
commitc36f19e02a96488f550fdb678c92500afca3109b
treeb446faa5bd5a0e506b20def0e5f0a1f210dce30a
parentd95a1b4818f2fe38a3cfc9a7d5817dc9a1a69329
[PATCH] Remove suspend() calls from shutdown path

This removes the calls to device_suspend() from the shutdown path that
were added sometime during 2.6.13-rc*.  They aren't working properly on
a number of configs (I got reports from both ppc powerbook users and x86
users) causing the system to not shutdown anymore.

I think it isn't the right approach at the moment anyway.  We have
already a shutdown() callback for the drivers that actually care about
shutdown and the suspend() code isn't yet in a good enough shape to be
so much generalized.  Also, the semantics of suspend and shutdown are
slightly different on a number of setups and the way this was patched in
provides little way for drivers to cleanly differenciate.  It should
have been at least a different message.

For 2.6.13, I think we should revert to 2.6.12 behaviour and have a
working suspend back.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
kernel/sys.c