]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] ocfs2: Release mutex in error handling code
authorJulia Lawall <julia@diku.dk>
Mon, 21 Jul 2008 07:59:15 +0000 (09:59 +0200)
committerMark Fasheh <mfasheh@suse.com>
Thu, 31 Jul 2008 23:21:14 +0000 (16:21 -0700)
commitc259ae52e204d42f8b2d484c85517a4c367030e1
treee5f9e57aeee77704758c6dfeb19654140a827ef2
parent961cecbee6786f4b1f1b8f695e87045b583f9f49
[PATCH] ocfs2: Release mutex in error handling code

The mutex is released on a successful return, so it would seem that it
should be released on an error return as well.

The semantic patch finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression l;
@@

mutex_lock(l);
... when != mutex_unlock(l)
    when any
    when strict
(
if (...) { ... when != mutex_unlock(l)
+   mutex_unlock(l);
    return ...;
}
|
mutex_unlock(l);
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
fs/ocfs2/file.c