]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
ext4: fix wrong use of do_div
authorSimon Holm Thøgersen <odie@cs.aau.dk>
Mon, 12 Jan 2009 03:34:01 +0000 (22:34 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 12 Jan 2009 03:34:01 +0000 (22:34 -0500)
commitc225aa57ff4ffe715df4692676b77c815a337236
treeaf70801def246873525ca5003b1a91adf91e024b
parent18e352e4a73465349711a9324767e1b2453383e2
ext4: fix wrong use of do_div

the following warning:

fs/jbd2/journal.c: In function ‘jbd2_seq_info_show’:
fs/jbd2/journal.c:850: warning: format ‘%lu’ expects type ‘long
unsigned int’, but argument 3 has type ‘uint32_t’

is caused by wrong usage of do_div that modifies the dividend in-place
and returns the quotient. So not only would an incorrect value be
displayed, but s->journal->j_average_commit_time would also be changed
to a wrong value!

Fix it by using div_u64 instead.

Signed-off-by: Simon Holm Thøgersen <odie@cs.aau.dk>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/jbd2/journal.c