]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
powerpc: fix fsl_upm nand driver modular build
authorAnton Vorontsov <avorontsov@ru.mvista.com>
Thu, 9 Oct 2008 00:32:59 +0000 (04:32 +0400)
committerKumar Gala <galak@kernel.crashing.org>
Mon, 13 Oct 2008 16:48:24 +0000 (11:48 -0500)
commitc0da99d5f7b0349cb11f970b3283c0d57beb5ec9
tree43c6bf5406b4f93ccb6fd7e1d47b3c1bafd6ebbe
parent1fb25be1e74498d389e4de819a6d1b174d6ccb7c
powerpc: fix fsl_upm nand driver modular build

The fsl_upm nand driver fails to build because fsl_lbc_lock isn't
exported, the lock is needed by the inlined fsl_upm_run_pattern()
function:

ERROR: "fsl_lbc_lock" [drivers/mtd/nand/fsl_upm.ko] undefined!

Dave Jones purposed to export the lock, but it is better to just uninline
the fsl_upm_run_pattern().

When uninlined we also no longer need the exported fsl_lbc_regs, and
both fsl_lbc_lock and fsl_lbc_regs could be marked static.

While at it, also add some missing includes that we should have included
explicitly.

Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
arch/powerpc/include/asm/fsl_lbc.h
arch/powerpc/sysdev/fsl_lbc.c