]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] Fix HD activity LED with ahci
authorMartin Wilck <martin.wilck@fujitsu-siemens.com>
Thu, 4 Aug 2005 07:04:56 +0000 (09:04 +0200)
committerJeff Garzik <jgarzik@pobox.com>
Tue, 23 Aug 2005 05:03:39 +0000 (01:03 -0400)
commitc0b34ad2956036cdba87792d6c46d8f491539df1
treeaff0dd3b2db8856aba533c7421acb78847f072e3
parent9309049544935f804b745aa4dea043fb39b2bf2a
[PATCH] Fix HD activity LED with ahci

Patch: fix wrong HD activity control by ahci driver

The ahci driver 1.0 sets the SActive bit on every transaction,
causing the LED to light up. The SActive bit is used only for
native command queuing (NCQ) which the current driver version
doesn't implement. Resetting the SActive bit is the device's
responsibility (by sending a "Set Device Bits FIS" to the
host adapter) but this is not required in response to
non-NCQ commands, and (most) devices don't. Thus the LED
stays always on. This patch fixes the LED behavior.

Spec references:
http://www.intel.com/technology/serialata/pdf/rev1_1.pdf, sec. 3.3.13, 5.5.1
http://www.serialata.org/docs/serialata10a.pdf
http://www.intel.com/design/storage/papers/25266401.pdf

Signed-off-by: Martin.Wilck@fujitsu-siemens.com
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
drivers/scsi/ahci.c