]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
tty: Fix race in the flush for some ldiscs
authorAlan Cox <alan@redhat.com>
Thu, 15 Jan 2009 13:30:25 +0000 (13:30 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 15 Jan 2009 20:48:35 +0000 (12:48 -0800)
commitc0253eec2a8e1140dd9672a1efe095cdcf5811d0
treec48dc5283ca4f01005295a97a28e532818aedce6
parent5393f780277165f282a37ed82dd878159ec9dad5
tty: Fix race in the flush for some ldiscs

If you issue an ioctl to flush a tty as the line discipline is changing or
otherwise unplugged you can get a crash. The bug is very old but the rest
of the BKL lock dropping and some very "good" luck on Ingo's part caught
an example.

Use the correct ldisc_ref form so that we wait for the ldisc change to
complete and then flush

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/char/tty_ioctl.c