]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[IA64] Delete iosapic_free_rte()
authorYasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Wed, 18 Jul 2007 06:47:34 +0000 (15:47 +0900)
committerTony Luck <tony.luck@intel.com>
Thu, 19 Jul 2007 21:03:55 +0000 (14:03 -0700)
commitbf903d0a4503db8ac166ca6135a59bc5f9b91a45
tree117a4dc0b1a1642b260651e2b81c366c886578e9
parente5bd762bda0d9aba8739a35f898479dc12e288a1
[IA64] Delete iosapic_free_rte()

>   arch/ia64/kernel/iosapic.c:597: warning: 'iosapic_free_rte' defined but not used
>
> This isn't spurious, the only call to iosapic_free_rte() has been removed, but there
> is still a call to iosapic_alloc_rte() ... which means we must have a memory leak.

I did it on purpose (and gave the warning a miss...) and I consider
iosapic_free_rte() is no longer needed.

I decided to remain iosapic_rte_info to keep gsi-to-irq binding
after device disable. Indeed it needs some extra memory, but it
is only "sizeof(iosapic_rte_info) * <the number of removed devices>"
bytes and has no memory leak becasue re-enabled devices use the
iosapic_rte_info which they used before disabling.

Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
arch/ia64/kernel/iosapic.c