]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
USB: drivers/usb/misc: Use an IS_ERR test rather than a NULL test
authorJulien Brunel <brunel@diku.dk>
Mon, 1 Sep 2008 08:57:27 +0000 (10:57 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 17 Oct 2008 21:40:53 +0000 (14:40 -0700)
commitbedf0883cbe3015d21aec5ed47ddffb429f6cca7
tree5a31171dcfa203f33dde74d040b704bccfc0fceb
parent58209018cfd6f1fa8d0139af7c39dbfe73de21fd
USB: drivers/usb/misc: Use an IS_ERR test rather than a NULL test

In case of error, the function backlight_device_register returns an
ERR pointer, but never returns a NULL pointer. So a NULL test that may
come after a call to this function should be strengthened by an IS_ERR
test.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@match_bad_null_test@
expression x, E;
statement S1,S2;
@@
x = backlight_device_register(...)
... when != x = E
* if (x != NULL)
S1 else S2
// </smpl>

Signed-off-by: Julien Brunel <brunel@diku.dk>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/misc/appledisplay.c