]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[XFS] fix filestreams on 32-bit boxes
authorEric Sandeen <sandeen@sandeen.net>
Thu, 30 Aug 2007 07:21:38 +0000 (17:21 +1000)
committerTim Shimmin <tes@chook.melbourne.sgi.com>
Thu, 20 Sep 2007 09:40:19 +0000 (19:40 +1000)
commitbcc7b445eff295664a3a3ab14e742b3c9d88e6e3
treec01cd93a01607b2fd3e05ba177e54f135607ea0f
parentb394e43e995d08821588a22561c6a71a63b4ff27
[XFS] fix filestreams on 32-bit boxes

xfs_filestream_mount() sets up an mru cache with:
  err = xfs_mru_cache_create(&mp->m_filestream, lifetime, grp_count,
  (xfs_mru_cache_free_func_t)xfs_fstrm_free_func);
but that cast is causing problems...
  typedef void (*xfs_mru_cache_free_func_t)(unsigned long, void*);
but:
  void xfs_fstrm_free_func( xfs_ino_t ino, fstrm_item_t *item)
so on a 32-bit box, it's casting (32, 32) args into (64, 32) and I assume
it's getting garbage for *item, which subsequently causes an explosion.
With this change the filestreams xfsqa tests don't oops on my 32-bit box.

SGI-PV: 967795
SGI-Modid: xfs-linux-melb:xfs-kern:29510a

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Tim Shimmin <tes@sgi.com>
fs/xfs/xfs_filestream.c