]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] uml: fix lvalue for gcc4
authorPaolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Thu, 14 Jul 2005 07:33:34 +0000 (00:33 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Thu, 14 Jul 2005 16:00:24 +0000 (09:00 -0700)
commitbcb01b8a67476e6f748086e626df8424cc27036d
tree02b2f7931e6d62273dc866863f600ee0b2f945b5
parent3952db66efee4f22f3c6a0fd02a1e7071556a8d6
[PATCH] uml: fix lvalue for gcc4

      Russell King <rmk+lkml@arm.linux.org.uk>

This construct is refused by GCC 4, so here's the (corrected) fix.  Thanks to
Russell for noticing a stupid mistake I did when first sending this.

As he noted, the code is largely suboptimal however it currently works, and
will be fixed shortly.  Just read the access_ok check on fp which is NULL, or
the pointer arithmetic below which should be done with a cast to void*:

  frame = (struct rt_sigframe __user *)
  round_down(stack_top - sizeof(struct rt_sigframe), 16) - 8;

The code shows clearly that has been taken from
arch/x86_64/kernel/signal.c:setup_rt_frame(), maybe in a bit of a hurry.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Cc: Jeff Dike <jdike@addtoit.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
arch/um/sys-x86_64/signal.c