]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[SCSI] libiscsi: grab eh_mutex during host reset
authorMike Christie <michaelc@cs.wisc.edu>
Thu, 13 Dec 2007 18:43:28 +0000 (12:43 -0600)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Sat, 12 Jan 2008 00:28:31 +0000 (18:28 -0600)
commitbc436b278776d22eb10e7e75bf3e5257d14550a9
tree98e3862e44333ef124becb957a0d0cd88ba24ed9
parentd8bf541e657824cb03effd726ac96e2f4dcf58a5
[SCSI] libiscsi: grab eh_mutex during host reset

I thought we may not need the eh mutex during host reset, but that is wrong
with the new shutdown code. When start_session_recovery sets the state to
terminate then drops the session lock. The scsi eh thread could then grab the
session lock see that we are terminating and then return failed to scsi-ml.
scsi-ml's eh then owns the command and will do whatever it wants
with it. But then the iscsi eh thread could grab the session lock
and want to complete the scsi commands that we in the LLD, but
it no longer owns them and kaboom.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/libiscsi.c