]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
netlink: Fix nla_parse_nested_compat() to call nla_parse() directly
authorThomas Graf <tgraf@suug.ch>
Thu, 22 May 2008 17:48:59 +0000 (10:48 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 22 May 2008 17:48:59 +0000 (10:48 -0700)
commitb9a2f2e450b0f770bb4347ae8d48eb2dea701e24
tree7f2d25b44259bdeb8dd35448bbf16f68aa1d5dd2
parent071f92d05967a0c8422f1c8587ce0b4d90a8b447
netlink: Fix nla_parse_nested_compat() to call nla_parse() directly

The purpose of nla_parse_nested_compat() is to parse attributes which
contain a struct followed by a stream of nested attributes.  So far,
it called nla_parse_nested() to parse the stream of nested attributes
which was wrong, as nla_parse_nested() expects a container attribute
as data which holds the attribute stream.  It needs to call
nla_parse() directly while pointing at the next possible alignment
point after the struct in the beginning of the attribute.

With this patch, I can no longer reproduce the reported leftover
warnings.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Acked-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/netlink.h