]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[XFS] Sanitise xfs_log_force error checking.
authorDavid Chinner <dgc@sgi.com>
Thu, 10 Apr 2008 02:24:30 +0000 (12:24 +1000)
committerLachlan McIlroy <lachlan@redback.melbourne.sgi.com>
Fri, 18 Apr 2008 02:02:20 +0000 (12:02 +1000)
commitb911ca0472c3762d2bafc4d21e432a9056844064
tree4ed23766782938e7316d087fa542cdbfd5fcadd7
parent234f56aca20a4f66b6ba3d3bf2787634dd9e0999
[XFS] Sanitise xfs_log_force error checking.

xfs_log_force() is declared to return an error, but we almost never check
it. We don't need to check it in most cases; if there's a log I/O error
then we'll be shutting down the filesystem anyway and that means we'll
catch the error somewhere else.

However, on certain calls we should be returning an error - sync
transactions, fsync, sync writes, etc. so this isn't a pure black and
white distinction. Hence make xfs_log_force() a void function that issues
a warning to the syslog on error, and call _xfs_log_force() in all the
places where we actually care about the error status returned.

SGI-PV: 980084
SGI-Modid: xfs-linux-melb:xfs-kern:30832a

Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Niv Sardi <xaiki@sgi.com>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
fs/xfs/xfs_log.c
fs/xfs/xfs_log.h
fs/xfs/xfs_rw.c