]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
thinkpad-acpi: fix module autoloading for older models
authorMathieu Chouquet-Stringer <mchouque@free.fr>
Sat, 14 Mar 2009 15:35:26 +0000 (16:35 +0100)
committerLen Brown <len.brown@intel.com>
Mon, 16 Mar 2009 04:38:24 +0000 (00:38 -0400)
commitb36a50f92d1c4300a88f606b4d2bbdc4f442a2d7
tree03e21e7ae7be7b3610b694fc91989b13ff3b6245
parent54b1ec893e869c815d390afa42aacf1499858112
thinkpad-acpi: fix module autoloading for older models

Looking at the source, there seems to be a missing * to match my DMI
string.  I mean for newer IBM and Lenovo's laptops you match either one
of the following:
MODULE_ALIAS("dmi:bvnIBM:*:svnIBM:*:pvrThinkPad*:rvnIBM:*");
MODULE_ALIAS("dmi:bvnLENOVO:*:svnLENOVO:*:pvrThinkPad*:rvnLENOVO:*");

While for older Thinkpads, you do this (for instance):
IBM_BIOS_MODULE_ALIAS("1[0,3,6,8,A-G,I,K,M-P,S,T]");

with IBM_BIOS_MODULE_ALIAS being MODULE_ALIAS("dmi:bvnIBM:bvr" __type "ET??WW")

Note there's no * terminating the string.  As result, udev doesn't load
anything because modprobe cannot find anything matching this (my
machine actually):

udevtest: run: '/sbin/modprobe dmi:bvnIBM:bvr1IET71WW(2.10):bd06/16/2006:svnIBM:pn236621U:pvrNotAv

Signed-off-by: Mathieu Chouquet-Stringer <mchouque@free.fr>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/platform/x86/thinkpad_acpi.c