]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] i386: clear_fixmap() should not use set_pte()
authorJan Beulich <jbeulich@novell.com>
Thu, 7 Dec 2006 01:14:09 +0000 (02:14 +0100)
committerAndi Kleen <andi@basil.nowhere.org>
Thu, 7 Dec 2006 01:14:09 +0000 (02:14 +0100)
commitb0bfece40b1988aa8e3d910938691dce7859d82d
tree4432a5231bcbda6161729839ae0b1eaa0861ac1f
parent9a457324229db34d3bcb0b67360130c287289401
[PATCH] i386: clear_fixmap() should not use set_pte()

While not strictly required with the current code (as the upper half of
page table entries generated by __set_fixmap() cannot be non-zero due
to the second parameter of this function being 'unsigned long'), the
use of set_pte() in __set_fixmap() in the context of clear_fixmap() is
still improper with CONFIG_X86_PAE (see the respective comment in
include/asm-i386/pgtable-3level.h) and would turn into a bug if that
second parameter ever gets changed to a 64-bit type.

Signed-off-by: Jan Beulich <jbeulich@novell.com>
Signed-off-by: Andi Kleen <ak@suse.de>
arch/i386/mm/pgtable.c