]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
jbd2: Add error check to journal_wait_on_commit_record to avoid oops
authorMingming Cao <cmm@u.ibm.com>
Tue, 5 Feb 2008 13:52:45 +0000 (08:52 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 5 Feb 2008 13:52:45 +0000 (08:52 -0500)
commitb048d8462652159c5314d19b191220b0ec384edb
tree06198272d89d7263d4d13df0ed00c3d0cf4e8aa0
parent531021f2ca681faf58f926771f85bb5c76f13eba
jbd2: Add error check to journal_wait_on_commit_record to avoid oops

The buffer head pointer passed to journal_wait_on_commit_record() could
be NULL if the previous journal_submit_commit_record() failed or journal
has already aborted.

Looking at the jbd2 debug messages, before the oops happened, the jbd2
is aborted due to trying to access the next log block beyond the end
of device. This might be caused by using a corrupted image.

We need to check the error returns from journal_submit_commit_record()
and avoid calling journal_wait_on_commit_record() in the failure case.

This addresses Kernel Bugzilla #9849

Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/jbd2/commit.c