]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
latencytop: fix kernel panic while reading latency proc file
authorHiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Thu, 14 Feb 2008 18:26:24 +0000 (10:26 -0800)
committerIngo Molnar <mingo@elte.hu>
Mon, 25 Feb 2008 15:34:17 +0000 (16:34 +0100)
commitae0027869db7d28563cd783865fab04ffd18419c
tree9d57da1dd823e9413fd539a4a60e09df6fe630f8
parent2d07b255c7b8a9723010e5c74778e058dc05162e
latencytop: fix kernel panic while reading latency proc file

Reading /proc/<pid>/latency or /proc/<pid>/task/<tid>/latency could cause
NULL pointer dereference.

In lstats_open(), get_proc_task() can return NULL, in which case the kernel
will oops at lstats_show_proc() because m->private is NULL.

When get_proc_task() returns NULL, the kernel should return -ENOENT.

This can be reproduced by the following script.
while :
do
        date
        bash -c 'ls > ls.$$' &
        pid=$!
        cat /proc/$pid/latency &
        cat /proc/$pid/latency &
        cat /proc/$pid/latency &
        cat /proc/$pid/latency
done

Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
fs/proc/base.c