]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
sctp: Fix oops when INIT-ACK indicates that peer doesn't support AUTH
authorVlad Yasevich <vladislav.yasevich@hp.com>
Thu, 18 Sep 2008 23:28:27 +0000 (16:28 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 18 Sep 2008 23:28:27 +0000 (16:28 -0700)
commitadd52379dde2e5300e2d574b172e62c6cf43b3d3
treec322f35beba73d356a44c1e31fed7a5791175eb6
parent0ef46e285c062cbe35d60c0adbff96f530d31c86
sctp: Fix oops when INIT-ACK indicates that peer doesn't support AUTH

If INIT-ACK is received with SupportedExtensions parameter which
indicates that the peer does not support AUTH, the packet will be
silently ignore, and sctp_process_init() do cleanup all of the
transports in the association.
When T1-Init timer is expires, OOPS happen while we try to choose
a different init transport.

The solution is to only clean up the non-active transports, i.e
the ones that the peer added.  However, that introduces a problem
with sctp_connectx(), because we don't mark the proper state for
the transports provided by the user.  So, we'll simply mark
user-provided transports as ACTIVE.  That will allow INIT
retransmissions to work properly in the sctp_connectx() context
and prevent the crash.

Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/associola.c
net/sctp/sm_make_chunk.c