]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
x86, kprobes: correct post-eip value in post_hander()
authorYakov Lerner <iler.ml@gmail.com>
Sun, 16 Mar 2008 08:21:21 +0000 (03:21 -0500)
committerIngo Molnar <mingo@elte.hu>
Thu, 17 Apr 2008 15:41:13 +0000 (17:41 +0200)
commitacb5b8a2dd0f901463d075382ea548935e679f4e
tree9f2a4e3bfab80dbdeb45c8f10a83840255c05470
parent0f54091051c450bab751c3ca0cb45d61a67a683b
x86, kprobes: correct post-eip value in post_hander()

I was trying to get the address of instruction to be executed
next after the kprobed instruction.  But regs->eip in post_handler()
contains value which is useless to the user. It's pre-corrected value.
This value is difficult to use without access to resume_execution(), which
is not exported anyway.
I moved the invocation of post_handler() to *after* resume_execution().
Now regs->eip contains meaningful value in post_handler().

I do not think this change breaks any backward-compatibility.
To make meaning of the old value, post_handler() would need access to
resume_execution() which is not exported.  I have difficulty to believe
that previous, uncorrected, regs->eip can be meaningfully used in
post_handler().

Signed-off-by: Yakov Lerner <iler.ml@gmail.com>
Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/kprobes.c