]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[POWERPC] spufs: use correct pg_prot for mapping SPU local store
authorArnd Bergmann <arnd@arndb.de>
Wed, 4 Oct 2006 15:26:16 +0000 (17:26 +0200)
committerPaul Mackerras <paulus@samba.org>
Wed, 4 Oct 2006 23:21:01 +0000 (09:21 +1000)
commitac91cb8dae061ced64e475d0d70fac4a95298819
tree70d82bc7abea0353157a1ba9d1aa58c41a555eff
parent6263203ed6e9ff107129a1ebe613290b342a4465
[POWERPC] spufs: use correct pg_prot for mapping SPU local store

This hopefully fixes a long-standing bug in the spu file system.
An spu context comes with local memory that can be either saved
in kernel pages or point directly to a physical SPE.

When mapping the physical SPE, that mapping needs to be cache-inhibited.
For simplicity, we used to map the kernel backing memory that way
too, but unfortunately that was not only inefficient, but also incorrect
because the same page could then be accessed simultaneously through
a cacheable and a cache-inhibited mapping, which is not allowed
by the powerpc specification and in our case caused data inconsistency
for which we did a really ugly workaround in user space.

Signed-off-by: Arnd Bergmann <arnd.bergmann@de.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/platforms/cell/spufs/file.c