]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] Fix snd-usb-audio in 32-bit compat environment
authorJuergen Kreileder <jk@blackdown.de>
Tue, 21 Feb 2006 02:28:00 +0000 (18:28 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Tue, 21 Feb 2006 04:00:10 +0000 (20:00 -0800)
commitaa657ca9245a06fa435e00332a13da1fce182abc
tree51e89251d12cd496cb502920467b8fa9a47b47b0
parenta9c930bac163c5e616ca0ba9378e7dc746c93227
[PATCH] Fix snd-usb-audio in 32-bit compat environment

I'm getting oopses with snd-usb-audio in 32-bit compat environments:
control_compat.c:get_ctl_type() doesn't initialize 'info', so
'itemlist[uinfo->value.enumerated.item]' in
usbmixer.c:mixer_ctl_selector_info() might access random memory (The 'if
((int)uinfo->value.enumerated.item >= cval->max)' doesn't fix all problems
because of the unsigned -> signed conversion.)

Signed-off-by: Juergen Kreileder <jk@blackdown.de>
Cc: Jaroslav Kysela <perex@suse.cz>
Acked-by: Takashi Iwai <tiwai@suse.de>
Cc: Greg KH <greg@kroah.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
sound/core/control_compat.c