]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] net/sb1000: replace nicedelay() with ssleep()
authorNishanth Aravamudan <nacc@us.ibm.com>
Mon, 20 Jun 2005 21:54:27 +0000 (23:54 +0200)
committerJeff Garzik <jgarzik@pobox.com>
Mon, 27 Jun 2005 03:47:57 +0000 (23:47 -0400)
commita26c074c1cf130df95e9c297ef98fdd98348acf0
treec595ac72c0b9cbda8f5a1f6513d2d529e4581389
parent62595eb9066ea09f7f8a789a38bec16d70ee0321
[PATCH] net/sb1000: replace nicedelay() with ssleep()

Use ssleep() instead of nicedelay()
to guarantee the task delays as expected. Remove the prototype and
definition of nicedelay(). This is a very weird function, because it is
called to sleep in terms of usecs, but always sleeps for 1 second,
completely ignoring the parameter. I have gone ahead and followed suit,
just sleeping for a second in all cases, but maybe someone with the
hardware could tell me if perhaps the paramter *should* matter. Additionally,
nicedelay() is called in TASK_INTERRUPTIBLE state, but doesn't deal with signals
in case these longer delays do not complete, so I believe ssleep() is more
appropriate.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
drivers/net/sb1000.c