]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
PCI: acpiphp: cleanup notify handler on all root bridges
authorAlex Chiang <achiang@hp.com>
Wed, 2 Jul 2008 02:02:23 +0000 (20:02 -0600)
committerJesse Barnes <jbarnes@virtuousgeek.org>
Wed, 2 Jul 2008 18:27:30 +0000 (11:27 -0700)
commita13307cef8bf51990ef1d525b1cbdcc2cfe07e2a
tree3098b0057aa09f53c9ecd485fc147f135eecfc33
parent99cb233d60cbe644203f19938c729ea2bb004d70
PCI: acpiphp: cleanup notify handler on all root bridges

During the development of the physical PCI slot patch series, Gary Hade
kept on reporting strange oopses due to interactions between pci_slot
and acpiphp.

http://lkml.org/lkml/2007/11/28/319

find_root_bridges() unconditionally installs
handle_hotplug_event_bridge() as an ACPI_SYSTEM_NOTIFY handler for all
root bridges.

However, during module cleanup, remove_bridge() will only remove the
notify handler iff the root bridge had a hot-pluggable slot directly
underneath. That is:

root bridge -> hotplug slot

But, if the topology looks like either of the following:

root bridge -> non-hotplug slot
root bridge -> p2p bridge -> hotplug slot

Then we currently do not remove the notify handler from that root
bridge.

This can cause a kernel oops if we modprobe acpiphp later and it gets
loaded somewhere else in memory. If the root bridge then receives a
hotplug event, it will then attempt to call a stale, non-existent notify
handler and we blow up.

Much thanks goes to Gary Hade for his persistent debugging efforts.

Signed-off-by: Alex Chiang <achiang@hp.com>
Signed-off-by: Gary Hade <garyhade@us.ibm.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
drivers/pci/hotplug/acpiphp_glue.c