]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
drivers/mmc: Move a dereference below a NULL test
authorJulia Lawall <julia@diku.dk>
Tue, 16 Dec 2008 15:13:09 +0000 (16:13 +0100)
committerPierre Ossman <drzeus@drzeus.cx>
Wed, 31 Dec 2008 17:18:14 +0000 (18:18 +0100)
commita0d045cac9bcb3e9a9796d596415f7ffb64852e2
tree961152a30a5b71d54c4a495f516284214f44ae00
parentf9134319c81c6c56e0ddf38e7adac2492b243d9b
drivers/mmc: Move a dereference below a NULL test

In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
drivers/mmc/host/tmio_mmc.c