]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] IRQ type flags
authorRussell King <rmk+lkml@arm.linux.org.uk>
Sun, 8 Jan 2006 09:02:07 +0000 (01:02 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Mon, 9 Jan 2006 04:13:46 +0000 (20:13 -0800)
commit9ded96f24c3a5fcbef954e88c443385a1af37eb9
tree49f43337e2b8d63a5a28402a15d99fe27d8d2a1c
parent705b6c7b34f2621f95f606d0e683daa10cdb8eb9
[PATCH] IRQ type flags

Some ARM platforms have the ability to program the interrupt controller to
detect various interrupt edges and/or levels.  For some platforms, this is
critical to setup correctly, particularly those which the setting is dependent
on the device.

Currently, ARM drivers do (eg) the following:

err = request_irq(irq, ...);

set_irq_type(irq, IRQT_RISING);

However, if the interrupt has previously been programmed to be level sensitive
(for whatever reason) then this will cause an interrupt storm.

Hence, if we combine set_irq_type() with request_irq(), we can then safely set
the type prior to unmasking the interrupt.  The unfortunate problem is that in
order to support this, these flags need to be visible outside of the ARM
architecture - drivers such as smc91x need these flags and they're
cross-architecture.

Finally, the SA_TRIGGER_* flag passed to request_irq() should reflect the
property that the device would like.  The IRQ controller code should do its
best to select the most appropriate supported mode.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
14 files changed:
arch/arm/kernel/irq.c
arch/arm/mach-omap1/serial.c
arch/arm/mach-pxa/corgi.c
arch/arm/mach-pxa/poodle.c
arch/arm/mach-pxa/spitz.c
arch/arm/mach-s3c2410/usb-simtec.c
drivers/i2c/chips/tps65010.c
drivers/input/keyboard/corgikbd.c
drivers/input/keyboard/spitzkbd.c
drivers/mfd/ucb1x00-core.c
drivers/net/smc91x.c
drivers/net/smc91x.h
include/asm-arm/irq.h
include/linux/signal.h