]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
drivers/ide/pci/sc1200.c: fix suspend/resume buglets and warnings
authorJeff Garzik <jeff@garzik.org>
Fri, 26 Oct 2007 18:31:15 +0000 (20:31 +0200)
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Fri, 26 Oct 2007 18:31:15 +0000 (20:31 +0200)
commit9d434813641abb5d619224e165f391bf352b202b
tree1a1f01279cba8ab1b947769a217fe084f6eb9f34
parentd5271be6b5601b3749cccd8ee89941d5868b90bf
drivers/ide/pci/sc1200.c: fix suspend/resume buglets and warnings

* We shouldn't bother with dev->current_state, the PCI API functions we
  call manage this for us (and do a far better job at it too).

* Remove pci_set_power_state(dev, PCI_D0) call in resume, as
  pci_enable_device() does the same thing.

* Check pci_enable_device() return value.  If it failed, fail
  the entire resume and avoid programming timings into the [potentially
  dead/asleep] chip.

Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
drivers/ide/pci/sc1200.c