]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
ATA: piix, fix pointer deref on suspend
authorJiri Slaby <jirislaby@gmail.com>
Wed, 3 Dec 2008 08:13:46 +0000 (09:13 +0100)
committerJeff Garzik <jgarzik@redhat.com>
Tue, 9 Dec 2008 05:43:54 +0000 (00:43 -0500)
commit9ac6212660fa3d8d0d21e782a22b956a6bc78a43
tree8e42713b7160b4a0160ef1fda59cc7e3ad82e609
parent2456eb819be7aa2cac73359c2855dfa30e46d75a
ATA: piix, fix pointer deref on suspend

Hi,

I've found this issue in the mmotm 2008-12-02-17-08.

--

Commit
ata_piix: add borked Tecra M4 to broken suspend list
introduced DMI variables checking, but they can be null, so that
we possibly dereference null.

Check if they are null and avoid checks in that case.

Solves:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
IP: [<ffffffff8043da97>] piix_pci_device_suspend+0x117/0x230

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Jeff Garzik <jgarzik@redhat.com>
Cc: Alexandru Romanescu <a_romanescu@yahoo.co.uk>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/ata_piix.c