]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] Add lookup_instantiate_filp usage warning
authorOleg Drokin <green@linuxhacker.ru>
Sat, 25 Mar 2006 11:07:02 +0000 (03:07 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sat, 25 Mar 2006 16:22:51 +0000 (08:22 -0800)
commit9a56c213929d83139fd1e12727e1037d71b519f8
tree013dd77c7cae23bd8fb821175a0d6fdc35bad9fe
parentb500531e6f5f234ed267bd7060ee06d144faf0ca
[PATCH] Add lookup_instantiate_filp usage warning

I think it would be nice to put an usage warning in header of
lookup_instantiate_filp() to indicate it is unsafe to use it on anything
but regular files (even that is potentially unsafe, but there your ->open()
is usually in your hands anyway), so that others won't fall into the same
trap I did.

Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/open.c