]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
rt2x00: Fix lock dependency errror
authorIvo van Doorn <ivdoorn@gmail.com>
Wed, 25 Jun 2008 19:27:00 +0000 (21:27 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 27 Jun 2008 18:49:52 +0000 (14:49 -0400)
commit980dfcb93232907034a2c92d62d3a7d6ac7bef44
treefbb8ed96c1ed2164ad507f57cb551bf2584da3a7
parent7ac3b02536c9ccfcc8aabc4c135a371ac4641805
rt2x00: Fix lock dependency errror

This fixes a circular locking dependency in the workqueue handling.
The interface work task uses the mac80211 function
ieee80211_iterate_active_interfaces() which grabs the RTNL lock.

However when the interface is brough down, this happens under the RTNL
lock as well, this causes problems because mac80211 will flush the workqueue
during the ifdown event. This causes mac80211 to wait until the driver has
completed all work which can't finish because it is waiting on the RTNL lock.

This is fixed by moving rt2x00 workqueue tasks on a different workqueue,
this workqueue can be flushed when the ieee80211_hw structure is removed
by the driver (when the driver is unloaded) which does not happen under the
RTNL lock.

Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rt2x00/rt2x00.h
drivers/net/wireless/rt2x00/rt2x00dev.c
drivers/net/wireless/rt2x00/rt2x00mac.c