]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
nfsd: do_probe_callback should not clear rpc stats
authorBenny Halevy <bhalevy@panasas.com>
Fri, 26 Sep 2008 12:14:13 +0000 (15:14 +0300)
committerJ. Bruce Fields <bfields@citi.umich.edu>
Mon, 29 Sep 2008 22:13:40 +0000 (18:13 -0400)
commit97eb89bb0e5d9ab20dbc677cb18fad1421473287
treebdb97a295476b8f934c6295b4a2faa9511311b30
parentdb820d6376aa81accf5b648651e160fd76e363e2
nfsd: do_probe_callback should not clear rpc stats

Now that cb_stats are static (since commit
ff7d9756b501744540be65e172d27ee321d86103)
there's no need to clear them.

Initially I thought it might make sense to do
that every callback probing but since the stats
are per-program and they are shared between possibly
several client callback instances, zeroing them out
seems like the wrong thing to do.

Note that that commit also introduced a bug
since stats.program is also being cleared in the process
and it is not restored after the memset as it used to be.

Signed-off-by: Benny Halevy <bhalevy@panasas.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
fs/nfsd/nfs4callback.c