]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
9p: drop broken unused error path from p9_conn_create()
authorTejun Heo <tj@kernel.org>
Mon, 13 Oct 2008 23:45:20 +0000 (18:45 -0500)
committerEric Van Hensbergen <ericvh@gmail.com>
Fri, 17 Oct 2008 16:04:42 +0000 (11:04 -0500)
commit95820a36516d12dcb49d066dd3d5b187a2557612
tree84ba5869e9f68b3c943e75feb7c634da1c61f47a
parent91b8534fa8f5e01f249b1bf8df0a2540053549ad
9p: drop broken unused error path from p9_conn_create()

Post p9_fd_poll() error path which checks m->poll_waddr[i] for PTR_ERR
value has the following problems.

* It's completely unused.  Error value is set iff NULL @wait_address
  has been specified to p9_pollwait() which is guaranteed not to
  happen.

* It dereferences @m after deallocating it (introduced by 571ffeaf and
  spotted by Raja R Harinath.

* It returned the wrong value on error.  It should return
  poll_waddr[i] but it returnes poll_waddr (introduced by 571ffeaf).

* p9_mux_poll_stop() doesn't handle PTR_ERR value.  It will try to
  operate on the PTR_ERR value as if it's a normal pointer and cause
  oops.

As the error path is bogus in the first place, there's no reason to
hold onto it.  Kill it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
Cc: Raja R Harinath <harinath@hurrynot.org>
net/9p/trans_fd.c