]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
RDMA/nes: Resurrect error path dead code
authorChien Tung <ctung@neteffect.com>
Thu, 21 Feb 2008 13:51:17 +0000 (07:51 -0600)
committerRoland Dreier <rolandd@cisco.com>
Tue, 26 Feb 2008 00:00:30 +0000 (16:00 -0800)
commit9300c0c06788a409a97d54bbe3360d2f385fc621
tree177ad00f8cbabaf84f561e3c98fca6b84f2dac1f
parent82d416fffb5e8e39e899be7075dbeeac5fb8f0c2
RDMA/nes: Resurrect error path dead code

Adrian Bunk pointed out that a Coverity scan found some apparently
dead code in nes_verbs.c that really shouldn't have been dead.

The function nes_create_cq() was missing the assignment

err = 1;

just prior to an iteration that conditionally set err = 0 if a PBL was
found for a given virtual CQ.  I also noticed we should have been
returning -EFAULT on a couple related error paths.

Signed-off-by: Chien Tung <ctung@neteffect.com>
Signed-off-by: Glenn Streiff <gstreiff@neteffect.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/hw/nes/nes_verbs.c