]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
net: Kill skb_truesize_check(), it only catches false-positives.
authorDavid S. Miller <davem@davemloft.net>
Wed, 18 Feb 2009 05:24:05 +0000 (21:24 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 18 Feb 2009 05:24:05 +0000 (21:24 -0800)
commit92a0acce186cde8ead56c6915d9479773673ea1a
tree97b7663f77f8274cb52d429c8a7db97c70daf745
parent34edaa88324004baf4884fb0388f86059d9c4878
net: Kill skb_truesize_check(), it only catches false-positives.

A long time ago we had bugs, primarily in TCP, where we would modify
skb->truesize (for TSO queue collapsing) in ways which would corrupt
the socket memory accounting.

skb_truesize_check() was added in order to try and catch this error
more systematically.

However this debugging check has morphed into a Frankenstein of sorts
and these days it does nothing other than catch false-positives.

Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/skbuff.h
include/net/sock.h
net/core/skbuff.c
net/core/sock.c