]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
mfd: twl4030-core irq simplification
authorDavid Brownell <dbrownell@users.sourceforge.net>
Wed, 8 Oct 2008 22:30:11 +0000 (00:30 +0200)
committerSamuel Ortiz <samuel@sortiz.org>
Sun, 19 Oct 2008 20:54:11 +0000 (22:54 +0200)
commit9297a0e7e033b7f2776610197fcbb9ff563efe32
tree669dea049a24ac9fc89d5506745fb386d620590f
parent26b8f5e1e2d1229c186d8e61d26513c43a058c5e
mfd: twl4030-core irq simplification

Simplify twl4030 IRQ handling by removing a needless custom flow
handler.  The top level IRQs, from the PIH, are well suited for
handle_simple_irq() ... they can't be acked or masked.

Switching resolves some issues with how IRQs were dispatched.
Notably, abuse of desc->status, IRQ accounting, and handling
of various faults.

In short, use standard genirq code.

Drivers that request_irq() to the PIH will need to pay more
attention to things like setting IRQF_DISABLED (since it's
no longer ignored), and making I2C calls from handlers (you'll
need a lockdep workaround).

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Samuel Ortiz <sameo@openedhand.com>
drivers/mfd/twl4030-core.c