]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
tcp: MD5: Fix MD5 signatures on certain ACK packets
authorAdam Langley <agl@imperialviolet.org>
Fri, 1 Aug 2008 03:49:48 +0000 (20:49 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 Aug 2008 03:49:48 +0000 (20:49 -0700)
commit90b7e1120bb43ffaabb88d28f80a0c2e13167b15
tree5264787eb3c303186cff15bfd6b7ebef2a3ecb7b
parent77e2f14f71d68d05945f1d30ca55b5194d6ab1ce
tcp: MD5: Fix MD5 signatures on certain ACK packets

I noticed, looking at tcpdumps, that timewait ACKs were getting sent
with an incorrect MD5 signature when signatures were enabled.

I broke this in 49a72dfb8814c2d65bd9f8c9c6daf6395a1ec58d ("tcp: Fix
MD5 signatures for non-linear skbs"). I didn't take into account that
the skb passed to tcp_*_send_ack was the inbound packet, thus the
source and dest addresses need to be swapped when calculating the MD5
pseudoheader.

Signed-off-by: Adam Langley <agl@imperialviolet.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_ipv4.c
net/ipv6/tcp_ipv6.c