]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
smsc911x: check for FFWD success before checking for timeout
authorSteve Glendinning <steve.glendinning@smsc.com>
Wed, 4 Mar 2009 07:33:24 +0000 (07:33 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 13 Mar 2009 19:14:09 +0000 (12:14 -0700)
commit8dacd548129d03e87751f75ea83b42a8a17ee651
tree7fcb04f42b116a303f1b446fbf201c8ebb004749
parent273ae44b9cb9443e0b5265cdc99f127ddb95c8db
smsc911x: check for FFWD success before checking for timeout

This patch from Juha Leppanen suppresses a false warning if a fast
forward operation succeeds on the very last attempt.

Juha> If smsc911x_reg_read loop is executed 500 times, timeout reaches 0
Juha> and the 500th smsc911x_reg_read result in val is ignored. If
Juha> testing order is changed, then val is checked first. The 500th
Juha> reg_read might be GOOD, why ignore it!

Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/smsc911x.c