]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
libata: revert convert-to-block-tagging patches
authorTejun Heo <tj@kernel.org>
Mon, 10 Nov 2008 05:48:21 +0000 (14:48 +0900)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 10 Nov 2008 16:04:47 +0000 (08:04 -0800)
commit8a8bc22332ee6ea49137508467a76aa7f4367719
treef41c62dc99c4249d592935b4659569081d4a190a
parentf7160c7573615ec82c691e294cf80d920b5d588d
libata: revert convert-to-block-tagging patches

This patch reverts the following three commits which convert libata to
use block layer tagging.

 43a49cbdf31e812c0d8f553d433b09b421f5d52c
 e013e13bf605b9e6b702adffbe2853cfc60e7806
 2fca5ccf97d2c28bcfce44f5b07d85e74e3cd18e

Although using block layer tagging is the right direction, due to the
tight coupling among tag number, data structure allocation and
hardware command slot allocation, libata doesn't work correctly with
the current conversion.

The biggest problem is guaranteeing that tag 0 is always used for
non-NCQ commands.  Due to the way blk-tag is implemented and how SCSI
starts and finishes requests, such guarantee can't be made.  I'm not
sure whether this would actually break any low level driver but it
doesn't look like a good idea to break such assumption given the
frailty of ATA controllers.

So, for the time being, keep using the old dumb in-libata qc
allocation.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Jens Axobe <jens.axboe@oracle.com>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/ata/libata-core.c
drivers/ata/libata-scsi.c
drivers/ata/libata.h
include/linux/libata.h