]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[DCCP]: calling dccp_v{4,6}_reqsk_send_ack is a BUG
authorGerrit Renker <gerrit@erg.abdn.ac.uk>
Fri, 10 Nov 2006 14:32:01 +0000 (12:32 -0200)
committerDavid S. Miller <davem@sunset.davemloft.net>
Sun, 3 Dec 2006 05:21:58 +0000 (21:21 -0800)
commit8a73cd09d96aa01743316657fc4e6864fe79b703
treefa22ed8ac78c5c76cc8ee3afd8bf72607290d42d
parentf6484f7c7ad22e4bb018875c386d6a7aaa441426
[DCCP]: calling dccp_v{4,6}_reqsk_send_ack is a BUG

This patch removes two functions, the send_ack functions of request_sock,
which are not called/used by the DCCP code. It is correct that these
functions are not called, below is a justification why calling these
functions (on a passive socket in the LISTEN/RESPOND state) would mean
a DCCP protocol violation.

A) Background: using request_sock in TCP:
net/dccp/dccp.h
net/dccp/ipv4.c
net/dccp/ipv6.c
net/dccp/minisocks.c