]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] fix floppy.c to store correct ro/rw status in underlying gendisk
authorJon Masters <jonathan@jonmasters.org>
Wed, 9 Nov 2005 05:34:43 +0000 (21:34 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Wed, 9 Nov 2005 15:55:53 +0000 (07:55 -0800)
commit88baf3e85af72f606363a85e9a60e9e61cc64a6c
tree6a887c40f55680b2494c98cd216f3cdafe1768e8
parent4448aaf0faafff3f275d15937c28b6346760e028
[PATCH] fix floppy.c to store correct ro/rw status in underlying gendisk

Evgeny Stambulchik found that doing the following always worked:

# mount /dev/fd0 /mnt/floppy/
mount: block device /dev/fd0 is write-protected, mounting read-only
# mount -o remount,rw /mnt/floppy
# echo $?
0

This is the case because the block device /dev/fd0 is writeable but the
floppy disk is marked protected.  A fix is to simply have floppy_open mark
the underlying gendisk policy according to reality (since the VFS doesn't
provide a way for do_remount_sb to inquire as to the current device
status).

Signed-off-by: Jon Masters <jcm@jonmasters.org>
Cc: Al Viro <viro@ftp.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/block/floppy.c