]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
x86 MCE: Fix CPU hotplug problem with multiple multicore AMD CPUs
authorRafael J. Wysocki <rjw@sisk.pl>
Fri, 22 Aug 2008 20:23:09 +0000 (22:23 +0200)
committerIngo Molnar <mingo@elte.hu>
Sat, 23 Aug 2008 15:49:19 +0000 (17:49 +0200)
commit8735728ef8dc935c4fb351f913758fdbb62c308d
tree5c96e2fcb2b326d2ad1ad3aa8294e7cbeab3d007
parent91ede005d72df60d6b3f252be177a4743a6aa46a
x86 MCE: Fix CPU hotplug problem with multiple multicore AMD CPUs

During CPU hot-remove the sysfs directory created by
threshold_create_bank(), defined in
arch/x86/kernel/cpu/mcheck/mce_amd_64.c, has to be removed before
its parent directory, created by mce_create_device(), defined in
arch/x86/kernel/cpu/mcheck/mce_64.c .  Moreover, when the CPU in
question is hotplugged again, obviously the latter has to be created
before the former.  At present, the right ordering is not enforced,
because all of these operations are carried out by CPU hotplug
notifiers which are not appropriately ordered with respect to each
other.  This leads to serious problems on systems with two or more
multicore AMD CPUs, among other things during suspend and hibernation.

Fix the problem by placing threshold bank CPU hotplug callbacks in
mce_cpu_callback(), so that they are invoked at the right places,
if defined.  Additionally, use kobject_del() to remove the sysfs
directory associated with the kobject created by
kobject_create_and_add() in threshold_create_bank(), to prevent the
kernel from crashing during CPU hotplug operations on systems with
two or more multicore AMD CPUs.

This patch fixes bug #11337.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Andi Kleen <andi@firstfloor.org>
Tested-by: Mark Langsdorf <mark.langsdorf@amd.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/cpu/mcheck/mce_64.c
arch/x86/kernel/cpu/mcheck/mce_amd_64.c
include/asm-x86/mce.h